Skip to content

roachprod: add faster restarts, prettier multi-node sql printing#120941

Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom
dt:roachprod-qol
Mar 26, 2024
Merged

roachprod: add faster restarts, prettier multi-node sql printing#120941
craig[bot] merged 3 commits intocockroachdb:masterfrom
dt:roachprod-qol

Conversation

@dt
Copy link
Copy Markdown
Contributor

@dt dt commented Mar 23, 2024

A couple minor quality-of-life improvements motivated by working on long-lived, multi-node DRT clusters.

dt added 2 commits March 23, 2024 13:39
During initial start we are careful to start nodes serially, in order, to
ensure the i'th VM's process acquires the i'th node ID. However this makes
startup much slower. We also initialize cluster settings.

When *restarting* the nodes of an existing cluster however, these steps are
not required: the node ID assignments are already persisted in the stores, as
are any previously set cluter settings. Thus we can elect to start all the
processes in parallel and skip init.

Release note: none.
Epic: none.
this ensures they don't get put after a --

Release note: none.
Epic: none.
@dt dt requested a review from herkolategan March 23, 2024 13:46
@dt dt requested a review from a team as a code owner March 23, 2024 13:46
@dt dt requested review from renatolabs and removed request for a team March 23, 2024 13:46
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

A common debugging flow is to ask raochprod to run some query on all nodes, eg.
roachprod sql mycluster -- -e 'select version()';

When the invoked statement returns multiple lines it makes sense to
a header above each result set, then the result set as it was returned.

However if the result set is a single line per node, printing just that
line, rather than a roachprod header and the result set's own header,
can make the aggregate result set much easier to read.

Release note: none.
Epic: none.
@dt dt force-pushed the roachprod-qol branch from 0ed73a0 to 72058a2 Compare March 23, 2024 16:06
Copy link
Copy Markdown
Collaborator

@herkolategan herkolategan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding!

@dt dt closed this Mar 26, 2024
@dt
Copy link
Copy Markdown
Contributor Author

dt commented Mar 26, 2024

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 26, 2024

Already running a review

@dt dt reopened this Mar 26, 2024
@dt
Copy link
Copy Markdown
Contributor Author

dt commented Mar 26, 2024

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 26, 2024

@craig craig bot merged commit 7247185 into cockroachdb:master Mar 26, 2024
@dt dt deleted the roachprod-qol branch March 28, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants