export: remove deprecated parquet library#120834
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Apr 1, 2024
Merged
export: remove deprecated parquet library#120834craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
@rharding6373 I believe CDC owns export now, so this should fall under our team for review. |
rharding6373
approved these changes
Mar 21, 2024
Collaborator
rharding6373
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
Contributor
Author
|
bors r=rharding6373 |
Contributor
Author
|
TYFR! |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed: |
Collaborator
|
The problem here is |
d60da18 to
a005796
Compare
rickystewart
requested changes
Mar 22, 2024
Collaborator
rickystewart
left a comment
There was a problem hiding this comment.
Looks like TestRandomParquetExports failed in CI. It seems like it's flaky.
Contributor
Author
|
The flake is related to this. Looking into it... #112693 |
55f4e9f to
7b8f8a2
Compare
This change removes the github.com/fraugster/parquet-go dependency and all code which uses it. This libary has been unused since cockroachdb#104234 landed. This change officially removes the code and dependency from the repo. This change also adds support for Oid-like types such as regrole, regtype etc to util/parquet. These types are used in export parquet testing and were previously not supported by util/parquet. Closes: cockroachdb#104278 Release note: None Epic: None
7b8f8a2 to
f9efe2b
Compare
Contributor
Author
|
bors r+ |
Contributor
|
👎 Rejected by code reviews |
rickystewart
approved these changes
Apr 1, 2024
Contributor
Author
|
TYFR! |
Contributor
Author
|
bors r+ |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the github.com/fraugster/parquet-go dependency and all code which uses it. This library has been unused since #104234 landed. This change officially removes the code and dependency from the repo.
This change also adds support for Oid-like types such as regrole, regtype etc to util/parquet. These types are
used in export parquet testing and were previously not supported by util/parquet.
Closes: #104278
Release note: None
Epic: None