ui: add charts on gc assist metric#119506
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing: 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
lyang24
left a comment
There was a problem hiding this comment.
Hi, i found a couple of examples monitoring metric examples are not up to date (as they still have network under hardware session and previous packet error and drop metrics missing).
I generated the grafana runtime.json file (based on monitoring/README.md) on my local machine it seems like a lot of a lot of fields were added to the previous code blocks possible due to the grafana version. I wonder if we should update them as a separate effort with another ticket to track it.
pkg/cmd/roachprod/grafana
monitoring/splunk-dashboard
monitoring/grafana-dashboards
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @nvanbenschoten)
This commit adds a line chart contains gc assist duration on the runtime page. The goal is to present the estimated time user go routines spend on assisting gc tasks. Informs: cockroachdb#118875 Release note: None
fba2e90 to
1fca1f6
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
nvb
left a comment
There was a problem hiding this comment.
I wonder if we should update them as a separate effort with another ticket to track it.
I think this makes sense. @dhartunian what is our current strategy for keeping all of this different metrics dashboards in sync?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
|
bors r+ |
|
Build succeeded: |
This commit adds a line chart contains gc assist duration on the runtime page. The goal is to present the estimated time user go routines spend on assisting gc tasks.
Informs: #118875
Release note: None
gc assist on crdb single node with kv workload gcttl=5s for database in (kv, system)
