Skip to content

bincheck: do not run geos tests on Windows#118797

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rail:bincheck-windows-no-geos
Feb 6, 2024
Merged

bincheck: do not run geos tests on Windows#118797
craig[bot] merged 1 commit intocockroachdb:masterfrom
rail:bincheck-windows-no-geos

Conversation

@rail
Copy link
Copy Markdown
Member

@rail rail commented Feb 5, 2024

In #106642 we stopped shipping libgeos on Windows, but didn't update the bincheck test to reflect the change.

Epic: none
Release note: None

In cockroachdb#106642 we stopped shipping libgeos on Windows, but didn't update the
bincheck test to reflect the change.

Epic: none
Release note: None
@rail rail added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-release T-release Release Engineering & Automation Team backport-23.2.x PAST MAINTENANCE SUPPORT: 23.2 patch releases via ER request only labels Feb 5, 2024
@rail rail requested a review from celiala February 5, 2024 23:49
@rail rail self-assigned this Feb 5, 2024
@rail rail requested a review from a team as a code owner February 5, 2024 23:49
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rail
Copy link
Copy Markdown
Member Author

rail commented Feb 6, 2024

bors r=celiala

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 6, 2024

Build succeeded:

@craig craig bot merged commit 804d37e into cockroachdb:master Feb 6, 2024
@rail rail deleted the bincheck-windows-no-geos branch March 14, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-release backport-23.2.x PAST MAINTENANCE SUPPORT: 23.2 patch releases via ER request only C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-release Release Engineering & Automation Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants