jobs,application_api: replace calls to skip.Stress with skip.Duress#118789
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 6, 2024
Merged
jobs,application_api: replace calls to skip.Stress with skip.Duress#118789craig[bot] merged 1 commit intocockroachdb:masterfrom
skip.Stress with skip.Duress#118789craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
celiala
approved these changes
Feb 5, 2024
Collaborator
celiala
left a comment
There was a problem hiding this comment.
LGTM - makes sense to me
Collaborator
Author
|
bors r=celiala |
Contributor
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
`skip.Duress()` seems like it should have been used in this case as it gives more time under both `race` and `deadlock`. This will give these tests some extra time if they run in a heavyweight configuration but not "under stress". Epic: CRDB-8308 Release note: None
772282c to
c211e8f
Compare
Collaborator
Author
|
bors r=celiala |
Contributor
|
Stopped waiting for PR status (GitHub check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests. |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skip.Duress()seems like it should have been used in this case as it gives more time under bothraceanddeadlock. This will give these tests some extra time if they run in a heavyweight configuration but not "under stress".Epic: CRDB-8308
Release note: None