Storage: show in logs when crdb_internal.compact_engine_span is called #111954#118719
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 2, 2024
Merged
Storage: show in logs when crdb_internal.compact_engine_span is called #111954#118719craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
|
Member
|
This change is |
Member
|
Sorry, I missed this. LGTM! bors r+ |
Contributor
|
👎 Rejected by too few approved reviews |
yuzefovich
approved these changes
May 2, 2024
Member
yuzefovich
left a comment
There was a problem hiding this comment.
bors r=raduberinde
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @RaduBerinde)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #111954
Description
This PR introduces log entries to indicate when crdb_internal.compact_engine_span is called. This improvement aims to facilitate debugging escalations.
Changes
Adding log statements whenever crdb_internal.compact_engine_span builtin is called
Release Note: None
Epic: none