kv: don't mutate tscache arena when serializing#118665
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 2, 2024
Merged
kv: don't mutate tscache arena when serializing#118665craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Fixes cockroachdb#118614. Fixes cockroachdb#118620. Fixes cockroachdb#118618. This commit fixes a bug where a call to `sklPage.serialize` could unintentionally mutate other keys in the sklPage's skiplist. This was possible because the append was called on a key that unexpectedly had extra capacity. We could use `slices.Clip` to fix this and mandate a memory copy, but we instead use `encoding.BytesNext`, which has a useful fast-path. While here, we do the same thing in `mergeSpans` to avoid an similar issues. Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
arulajmani
approved these changes
Feb 2, 2024
Collaborator
arulajmani
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118614.
Fixes #118620.
Fixes #118618.
This commit fixes a bug where a call to
sklPage.serializecould unintentionally mutate other keys in the sklPage's skiplist. This was possible because the append was called on a key that unexpectedly had extra capacity.We could use
slices.Clipto fix this and mandate a memory copy, but we instead useencoding.BytesNext, which has a useful fast-path.While here, we do the same thing in
mergeSpansto avoid an similar issues.Release note: None