catalog/lease: handle retryable replica errors properly#118646
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 2, 2024
Merged
catalog/lease: handle retryable replica errors properly#118646craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously, the expiration based leasing mechanism was used, which was more lenient for duplicate rows in the system.lease table. Certain retryable errors like replica errors could lead to rows being written, but not being cleaned up with the assumption nothing was written. In the session based model we are strict and require a single row per descriptor, version and session, so any errors not handled properly will lead to future failures. To address this, this patch with treat both ambiguous result errors and replica errors as retryable. When these are hit the lease will be deleted and re-inserted in case an existing one was persisted. Fixes: cockroachdb#118520 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
rafiss
approved these changes
Feb 2, 2024
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
great find! glad we already had IsRetryableReplicaError
Collaborator
Author
|
@rafiss TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the expiration based leasing mechanism was used, which was more lenient for duplicate rows in the system.lease table. Certain retryable errors like replica errors could lead to rows being written, but not being cleaned up with the assumption nothing was written. In the session based model we are strict and require a single row per descriptor, version and session, so any errors not handled properly will lead to future failures. To address this, this patch with treat both ambiguous result errors and replica errors as retryable. When these are hit the lease will be deleted and re-inserted in case an existing one was persisted.
Fixes: #118520
Release note: None