kv/tscache: remove propagation of synthetic timestamp bit#117015
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jan 4, 2024
Merged
kv/tscache: remove propagation of synthetic timestamp bit#117015craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Informs cockroachdb#101938. This commit is essentially a revert of cc61e09. It removes the propagation of the synthetic flag through the timestamp cache. This flag has been deprecated since v22.2 and is no longer consulted in uncertainty interval checks or by transaction commit-wait. It does not need to be propagated from readers to writers during read-write txn conflicts. Release note: None
Small cleanup. Would have prevented an initial bug in previous commit. Epic: None Release note: None
d92ded7 to
f29448b
Compare
arulajmani
approved these changes
Jan 4, 2024
Collaborator
arulajmani
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Informs #101938.
This commit is essentially a revert of cc61e09. It removes the propagation of the synthetic flag through the timestamp cache.
This flag has been deprecated since v22.2 and is no longer consulted in uncertainty interval checks or by transaction commit-wait. It does not need to be propagated from readers to writers during read-write txn conflicts.
Release note: None