roachtest/cdc: disable distribution strategy in old versions #116888
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 20, 2023
Merged
roachtest/cdc: disable distribution strategy in old versions #116888craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
The `DistributionStrategy` feature flag was added to randomly set the `changefeed.default_range_distribution_strategy` cluster setting. Since this setting was added in 23.2, this feature flag should be disabled when testing versions < 23.2. This change updates the feature flag to not be set in versions < 23.2. It also refactors how enum feature flags work: they should use the `featureUnset`, `featureDisabled`, and `featureEnabled` states. For enum feature flags, unset and disabled can be considered equivalent (ie. for a cluster setting which is an enum, don't set a value). In the future, this can be changed to add a specific case for disabled. For now, this suffices. Closes: cockroachdb#116865 Release note: None Epic: None
463db09 to
d181aee
Compare
miretskiy
approved these changes
Dec 20, 2023
Contributor
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oachtest/cdc: disable distribution strategy in old versions
The
DistributionStrategyfeature flag was added to randomly set thechangefeed.default_range_distribution_strategycluster setting. Since this settingwas added in 23.2, this feature flag should be disabled when testing versions < 23.2.
This change updates the feature flag to not be set in versions < 23.2. It also
refactors how enum feature flags work: they should use the
featureUnset,featureDisabled,and
featureEnabledstates. For enum feature flags, unset and disabled can be consideredequivalent (ie. for a cluster setting which is an enum, don't set a value). In the future,
this can be changed to add a specific case for disabled. For now, this suffices.
Closes: #116865
Release note: None
Epic: None