kv: implement BatchRequest methods on pointer receivers#116696
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 3, 2024
Merged
kv: implement BatchRequest methods on pointer receivers#116696craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
be66cb6 to
0aeec2d
Compare
lyang24
approved these changes
Jan 2, 2024
Contributor
lyang24
left a comment
There was a problem hiding this comment.
Thank you, I pulled the branch and tested redact.SafeFormatter conversion lgtm!
The commit changes the receiver type of the BatchRequest methods to pointer receivers. This allows *BatchRequest to implement the redact.SafeFormatter interface, which is helpful now that (as of e822649) BatchRequest is always passed around by pointer. Release note: None
0aeec2d to
2f7bf07
Compare
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit changes the receiver type of the BatchRequest methods to pointer receivers. This allows *BatchRequest to implement the redact.SafeFormatter interface, which is helpful now that (as of e822649) BatchRequest is always passed around by pointer.
Informs #114601.
Release note: None