sql: add telemetry for mixed DDL/DML transactions#116614
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 18, 2023
Merged
sql: add telemetry for mixed DDL/DML transactions#116614craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This patch adds feature counter telemetry for explicit transactions that have schema changes. We track is a transaction has DDL only or a mixture of DDL and DML, and if it succeeded or failed. Release note: None
Member
|
This change is |
fqazi
approved these changes
Dec 18, 2023
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
Nice work!
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
pkg/sql/conn_executor_exec.go line 1535 at r1 (raw file):
// recordDDLTxnTelemetry records telemetry for explicit transactions that // contain DDL. func (ex *connExecutor) recordDDLTxnTelemetry(failed bool) {
Might be worth taking in an err here if we want to analyze failed rollbacks too in the future.
Collaborator
Author
|
bors r+ |
rafiss
commented
Dec 18, 2023
Collaborator
Author
rafiss
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/sql/conn_executor_exec.go line 1535 at r1 (raw file):
Previously, fqazi (Faizan Qazi) wrote…
Might be worth taking in an err here if we want to analyze failed rollbacks too in the future.
from talking with Dikshant, these should just be counted under the TransactionFailure metrics
Contributor
|
Build succeeded: |
This was referenced Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds feature counter telemetry for explicit transactions that have schema changes. We track if a transaction has DDL only or a mixture of DDL and DML, and if it succeeded or failed.
fixes #115012
Release note: None