roachtest: pass startopts to SetDefaultPort helpers by reference#116452
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Dec 14, 2023
Merged
roachtest: pass startopts to SetDefaultPort helpers by reference#116452craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Startopts was being passed by value, effectively making the helpers noops. Release note: none Epic: none
8b8b023 to
5ea4f65
Compare
Contributor
Author
srosenberg
approved these changes
Dec 14, 2023
RaduBerinde
approved these changes
Dec 14, 2023
Member
RaduBerinde
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @herkolategan and @renatolabs)
renatolabs
approved these changes
Dec 14, 2023
Contributor
Author
|
Tests all passed, TFTRs bors r=srosenberg, RaduBerinde, renatolabs |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startopts was being passed by value, effectively making the helpers noops.
Release note: none
Epic: none
Fixes: #116432
Fixes: #116433
Fixes: #116485