Skip to content

kvserver: remove ReplicaID migration#115884

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
erikgrinaker:replica-id-migration
Jan 4, 2024
Merged

kvserver: remove ReplicaID migration#115884
craig[bot] merged 1 commit intocockroachdb:masterfrom
erikgrinaker:replica-id-migration

Conversation

@erikgrinaker
Copy link
Copy Markdown
Contributor

@erikgrinaker erikgrinaker commented Dec 8, 2023

This migration ensured every replica had a persisted replica ID. It is no longer needed after MinSupportedVersion >= 23.1, since the migration has been applied on every finalized 23.1 node. Instead, we assert during startup that all replicas have a replica ID.

Resolves #115869.
Touches #95513.
Epic: none
Release note: None

@erikgrinaker erikgrinaker requested a review from pav-kv December 8, 2023 18:02
@erikgrinaker erikgrinaker self-assigned this Dec 8, 2023
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@erikgrinaker erikgrinaker marked this pull request as ready for review January 4, 2024 09:26
@erikgrinaker erikgrinaker requested a review from a team January 4, 2024 09:26
This migration ensured every replica had a persisted replica ID. It is
no longer needed after `MinSupportedVersion` >= 23.1, since the
migration has been applied on every finalized 23.1 node. Instead, we
assert during startup that all replicas have a replica ID.

Epic: none
Release note: None
@erikgrinaker
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 4, 2024

Build succeeded:

@craig craig bot merged commit cbe17c3 into cockroachdb:master Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kvserver: remove Raft migrations during replica initialization

3 participants