settings: store unencoded ClusterVersion in version setting#114087
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 8, 2023
Merged
settings: store unencoded ClusterVersion in version setting#114087craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
We currently store the `ClusterVersion` as a protobuf encoded `[]byte`. This requires unmarshaling in hot paths like `IsActive`. This change switches to storing the `ClusterVersion` directly. Fixes: cockroachdb#113385 Release note: None
Member
|
This change is |
pav-kv
approved these changes
Nov 8, 2023
Collaborator
pav-kv
left a comment
There was a problem hiding this comment.
Thanks. Curious how much this improves BenchmarkClusterVersionSettingIsActive.
Member
Author
|
TFTR! On my macbook: bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently store the
ClusterVersionas a protobuf encoded[]byte. This requires unmarshaling in hot paths likeIsActive.This change switches to storing the
ClusterVersiondirectly.Fixes: #113385
Release note: None