roachprod: fix initialization of 1-node clusters#114025
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 8, 2023
Merged
roachprod: fix initialization of 1-node clusters#114025craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Author
|
Build with |
In cockroachdb#113718, we changed how initialization is done in order to remove the concurrent start of cockroach process. In that change, we also unified the `shouldInit` variable that controls whether the cluster should be initialized with `cockroach init`. However, that particular change was a mistake: it conflated cluster initialization with whether "startup tasks" should run. This commit fixes that issue by separating the two concepts; now one-node clusters should still skip `cockroach init`, but they will run startup tasks as usual. Fixes: cockroachdb#114015. Release note: None
535f900 to
dd55d15
Compare
RaduBerinde
approved these changes
Nov 8, 2023
herkolategan
approved these changes
Nov 8, 2023
Author
|
TFTRs! bors r=RaduBerinde,herkolategan |
Contributor
|
Build succeeded: |
This was referenced Nov 8, 2023
This was referenced Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #113718, we changed how initialization is done in order to remove the concurrent start of cockroach process. In that change, we also unified the
shouldInitvariable that controls whether the cluster should be initialized withcockroach init. However, that particular change was a mistake: it conflated cluster initialization with whether "startup tasks" should run.This commit fixes that issue by separating the two concepts; now one-node clusters should still skip
cockroach init, but they will run startup tasks as usual.Fixes: #114015.
Release note: None