Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @annrpom, @renatolabs, and @srosenberg)

pkg/cmd/roachtest/tests/secondary_indexes.go line 57 at r1 (raw file):

		// Modify index data from that node.
		modifyData(1,

the old code took care to run this command on the node whose binary was upgraded. i don't think the new framework offers us that control. is that correct @renatolabs? it may be sufficient to just rely on randomization here.

, but in the theme of efficiency, this is another test that I wish didn't spin up real VMs.

Nothing for this test to do right now, I think the better course of action is to set up a nightly "Local roachtest" run for tests like this and the validate-schema one recently ported.

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @annrpom, @rafiss, and @srosenberg)

pkg/cmd/roachtest/tests/secondary_indexes.go line 57 at r1 (raw file):

You can achieve the same goal with in the new test with:

upgradeContext := h.Context()
nextVersionDB := func() *gosql.DB {
    upgrading := upgradeContext.ToVersion.Compare(upgradeContext.FromVersion) > 0
    var node int
    var db *gosql.DB
    if upgrading {
        node, db = h.RandomDB(rng, upgradeContext.ToVersion)
    } else {
        node, db = h.RandomDB(rng, upgradeContext.FromVersion) // downgrading
    }

    l.Printf("connecting to n%d", node)
    return db
}

nextVersionDB().ExecContext(/* ... */)

There's a recent higher level API being introduced in a WIP PR, but the above should achieve that goal with what exists today. I'll add a note to update this test once that's ready.