roachtest: remove cloud from registry and ClusterSpec#113505
roachtest: remove cloud from registry and ClusterSpec#113505craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
8a18ebe to
4c2d872
Compare
renatolabs
left a comment
There was a problem hiding this comment.
Minor comments, nice work!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde and @srosenberg)
pkg/cmd/roachtest/spec/cluster_spec.go line 252 at r1 (raw file):
// - the existing cluster's arch, if we are reusing a cluster; // - otherwise, it is the test' // it; it is not guaranteed
Documentation is off here.
pkg/cmd/roachtest/spec/cluster_spec.go line 348 at r1 (raw file):
// based on the cloud and CPU count. var err error switch params.Cloud {
Nit: we're switching on cloud directly above; might make sense to do this here too to lower cognitive load.
4c2d872 to
d58b043
Compare
RaduBerinde
left a comment
There was a problem hiding this comment.
TFTR!
Reviewable status:
pkg/cmd/roachtest/spec/cluster_spec.go line 252 at r1 (raw file):
Previously, renatolabs (Renato Costa) wrote…
Documentation is off here.
Done. Not sure where the change came from, reverted.
d3b5d32 to
a392efb
Compare
This change is the last step in removing runtime state from the test registry and the cluster spec. The cloud is no longer accessible at test registration time. Fixes cockroachdb#104029 Release note: None
a392efb to
c6a8e62
Compare
|
Rebased and started test run: https://teamcity.cockroachdb.com/viewQueued.html?itemId=12554668 |
|
bors r+ |
|
Build succeeded: |
This change is the last step in removing runtime state from the test
registry and the cluster spec. The cloud is no longer accessible at
test registration time.
Fixes #104029
Release note: None