roachtest: delete version/mixed tests#113323
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 31, 2023
Merged
Conversation
Member
|
This change is |
c301bef to
c4ce11d
Compare
This commit deletes the version/mixed roachtests. These tests do very little, only testing that upgrades finish. This is tested by other mixed-version tests, rendering these tests redundant. Note that these tests did test upgrades for clusters of size 5, something we don't do elsewhere. However it isn't worth it to have a seperate test for this. Release note: None Epic: CRDB-19321 Fixes: cockroachdb#110538 Informs: cockroachdb#110528
c4ce11d to
832bbc5
Compare
Contributor
Author
|
TFTR! bors r=renatolabs |
Contributor
|
Build succeeded: |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit deletes the version/mixed roachtests. These tests do very little, only testing that upgrades finish. This is tested by other mixed-version tests, rendering these tests redundant.
Note that these tests did test upgrades for clusters of size 5, something we don't do elsewhere. However it isn't worth it to have a separate test for this.
Release note: None
Epic: CRDB-19321
Fixes: #110538
Informs: #110528