roachtest: reenable Jepsen subcritical-skews test#112710
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 20, 2023
Merged
roachtest: reenable Jepsen subcritical-skews test#112710craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
The Jepsen version we are using already moved from `ntp.ubuntu.org` to `pool.ntp.org`. We should be able to run these tests again. https://github.com/cockroachdb/jepsen/blob/cdeef40a0cd24af0c989e0a7990ee1c7fa948f43/cockroachdb/src/jepsen/cockroach/time.clj#L27 Fixes: cockroachdb#35599 Release note: None
6fa42dc to
32f7a71
Compare
Author
|
Subcritical-skews tests passed: https://teamcity.cockroachdb.com/viewLog.html?buildId=12260161&buildTypeId=Cockroach_Nightlies_RoachtestNightlyGceBazel&tab=testsInfo&branch_Cockroach_Nightlies=112710. Still remains to be seen whether we'll get rate limited over time, but I think it's worth re-enabling these tests and seeing what happens. |
DarrylWong
approved these changes
Oct 20, 2023
Author
|
TFTR! bors r=DarrylWong |
Contributor
|
Build succeeded: |
This was referenced Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Jepsen version we are using already moved from
ntp.ubuntu.orgtopool.ntp.org. We should be able to run these tests again.https://github.com/cockroachdb/jepsen/blob/cdeef40a0cd24af0c989e0a7990ee1c7fa948f43/cockroachdb/src/jepsen/cockroach/time.clj#L27
Fixes: #35599
Release note: None