zonepb: add expected/actual values to validation errors#112704
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 19, 2023
Merged
zonepb: add expected/actual values to validation errors#112704craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
8568585 to
ade1d3e
Compare
chrisseto
approved these changes
Oct 19, 2023
Contributor
chrisseto
left a comment
There was a problem hiding this comment.
LGTM, thanks for the improvements!
This will make it slightly easier to debug errors where this validation fails. Release note: None
ade1d3e to
fefd104
Compare
Collaborator
Author
|
tftr! flake was #112659 bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make it slightly easier to debug errors where this validation fails.
informs #111299
Release note: None