release: verify version.txt in Pick SHA#112687
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 19, 2023
Merged
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
98d00fa to
3e1ad2d
Compare
Previously, we did not verify the contents of the version.txt file as a part of the Pick SHA step. In case the guessed version doesn't match the contents of the file, we have to delay the release by many hours to allow CI automation work. This PR adds a check in the Pick SHA step to verify the version. Fixes: RE-438 Release note: None
3e1ad2d to
208c24b
Compare
Member
Author
|
bors r=celiala |
Contributor
|
Build succeeded: |
This was referenced Oct 19, 2023
Collaborator
|
Nice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we did not verify the contents of the version.txt file as a part of the Pick SHA step. In case the guessed version doesn't match the contents of the file, we have to delay the release by many hours to allow CI automation work.
This PR adds a check in the Pick SHA step to verify the version.
Fixes: RE-438
Release note: None
Release justification: release automation changes