clusterversion: bump version to 24.1#112271
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 19, 2023
Merged
Conversation
Member
|
This change is |
2c2fef2 to
4955c46
Compare
15beef6 to
3b47e0c
Compare
3b47e0c to
722bf13
Compare
e3ff2f9 to
1ee2c72
Compare
celiala
approved these changes
Oct 19, 2023
Collaborator
celiala
left a comment
There was a problem hiding this comment.
The mapping for cockroach_releases.yaml should instead be:
- 23.2 --> predecessor: 23.1
- 24.1 --> predecessor: 23.2
i.e. so leave existing one, but add a new key/value for 24.1
Otherwise, LGTM! Thanks for all the work!
Reviewed 19 of 59 files at r5, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @michae2, @msbutler, and @RaduBerinde)
pkg/testutils/release/cockroach_releases.yaml line 21 at r5 (raw file):
- 23.1.0 predecessor: "22.2" "24.1":
This should be:
23.2 --> predecessor: 23.1
24.1 --> predecessor: 23.2
celiala
reviewed
Oct 19, 2023
Collaborator
celiala
left a comment
There was a problem hiding this comment.
We synced offline about cockroach_releases.yaml:
- change in PR is autogenerated + expected
- script that updates it will make it look as expected once we publish 23.2.0-beta.1 (as part of the runbook for publishing releases)
Reviewable status:
Member
Author
|
Thank you! bors r+ |
This commit enacts the following steps: - add `V23_2` release version key - add `V24_1Start` version key - add `V24` version key alias - add `local-mixed-23.2` logictest config - create new bootstrap files (from the testdata), add to initial values map - update `pkg/build/version.txt` to `v24.1.0-alpha.00000000` - update releases file: ``` bazel build //pkg/cmd/release:release _bazel/bin/pkg/cmd/release/release_/release update-releases-file ``` We also make a small cleanup change to remove `firstUpgradesAfterPreExistingReleases` and instead use a helper function for first upgrades (and check that all `Start` versions have the expected description). Epic: none Release note: None
1ee2c72 to
f74fff6
Compare
Contributor
|
Canceled. |
Member
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This was referenced Oct 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enacts the following steps:
V23_2release version keyV24_1Startversion keyV24version key aliaslocal-mixed-23.2logictest configvalues map
pkg/build/version.txttov24.1.0-alpha.00000000We also make a small cleanup change to remove
firstUpgradesAfterPreExistingReleasesand instead use a helperfunction for first upgrades (and check that all
Startversions havethe expected description).
Epic: none
Release note: None