streamingccl: fix test flake#112166
Closed
stevendanna wants to merge 1 commit intocockroachdb:masterfrom
Closed
Conversation
Currently, tenant servers are slow to shut down after a STOP SERVICE. This can cause flakes because (1) it is unsafe to revert a tenant that is still writing and (2) the test assumes it can connect anew after bringing the tenant back online, but the tenant might still be draining. Epic: none Release note: None
Member
|
This change is |
This was referenced Oct 13, 2023
adityamaru
approved these changes
Oct 13, 2023
Collaborator
Author
|
Merged as part of #112295 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, tenant servers are slow to shut down after a STOP SERVICE. This can cause flakes because (1) it is unsafe to revert a tenant that is still writing and (2) the test assumes it can connect anew after bringing the tenant back online, but the tenant might still be draining.
Epic: none
Release note: None