cast: remove invalid casts for REFCURSOR#111884
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 6, 2023
Merged
cast: remove invalid casts for REFCURSOR#111884craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
51f2b33 to
10e991b
Compare
10e991b to
e4a944b
Compare
Collaborator
Author
|
Sorry for the force-pushes; the commit message was a bit mangled. |
Collaborator
Author
|
Hold off on this one for now; I think REFCURSOR needs its own type family. |
e4a944b to
e5c5577
Compare
mgartner
approved these changes
Oct 6, 2023
Contributor
mgartner
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
Collaborator
Author
|
TFTR! |
The initial implementation for the `REFCURSOR` data type included assignment casts from and explicit casts to every other type. In postgres, `REFCURSOR` has only the following valid casts: 1. Explicit casts from each string type. 2. Assignment casts to each string type. This patch aligns the casts for `REFCURSOR` with those of postgres, and adds according tests. Informs cockroachdb#111560 Release note: None
e5c5577 to
890154d
Compare
Collaborator
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cast: remove invalid casts for REFCURSOR
The initial implementation for the
REFCURSORdata type includedassignment casts from and explicit casts to every other type. In postgres,
REFCURSORhas only the following valid casts:This patch aligns the casts for
REFCURSORwith those of postgres, andadds according tests.
Informs #111560
Release note: None