server,kvcoord: change x-locality log from vevent to vinfo#111442
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Sep 29, 2023
Merged
server,kvcoord: change x-locality log from vevent to vinfo#111442craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
7ee11d3 to
770d171
Compare
20bc25f to
e3365c2
Compare
arulajmani
approved these changes
Sep 29, 2023
Collaborator
arulajmani
left a comment
There was a problem hiding this comment.
Thanks for doing this!
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @kvoli)
The X-locality log events were added in cockroachdb#104585 to the Node batch receive path, to alert when localities were misconfigured. In some clusters, especially test clusters, these events are unnecessarily verbose in traces. Change the log from `VEvent(5)` to `VInfo(5)` in the node batch path. Part of: cockroachdb#110648 Epic: none Release note: None
The X-locality log events were added in cockroachdb#103963 for the dist sender, to alert when localities were misconfigured. In some clusters, especially test clusters, these events are unnecessarily verbose in traces. Change the log from `VEvent(5)` to `VInfo(5)` in the dist sender path. Resolves: cockroachdb#110648 Epic: none Release note: None
e3365c2 to
3412f90
Compare
Contributor
Author
|
Rebased on master. |
Contributor
Author
|
Failure on extended is unrelated and tracked in #111492. TYFTR! bors r=arulajmani |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The X-locality log events were added in #104585 to the Node batch
receive path, to alert when localities were misconfigured. In some
clusters, especially test clusters, these events are unnecessarily
verbose in traces.
Change the log from
VEvent(5)toVInfo(5)in the node batch path.The X-locality log events were added in #103963 for the dist sender, to
alert when localities were misconfigured. In some clusters, especially
test clusters, these events are unnecessarily verbose in traces.
Change the log from
VEvent(5)toVInfo(5)in the dist sender path.Resolves: #110648
Epic: none
Release note: None