roachtest: automatically profile CPU in restore tests#111434
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Sep 28, 2023
Merged
roachtest: automatically profile CPU in restore tests#111434craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Epic: none Release note: none
Member
|
This change is |
Collaborator
Author
|
Example of a successful test run ( 
CPU peaked at almost 79%. So, the default recommended threshold of 80% makes sense. |
msbutler
approved these changes
Sep 28, 2023
Collaborator
Author
|
bors r=msbutler |
Contributor
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from c516881 to blathers/backport-release-23.1-111434: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://www.cockroachlabs.com/docs/v23.1/automatic-cpu-profiler.
NB: the
server.cpu_profile.enabledsetting is not used because it was recently removed in #107717. It should be used if this change is backported.Touches #111160, #111159
Epic: none
Release note: none