kv: add shared, replicated, and shared-replicated locks to TestEvaluateBatch#111433
Conversation
|
This change is |
arulajmani
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten)
pkg/kv/kvserver/replica_evaluate_test.go line 321 at r1 (raw file):
setup: func(t *testing.T, d *data) { writeABCDEFAt(t, d, ts.Prev()) scanA := getArgsString("a")
nit: Should these say "getA" and "getG", here and elsewhere?
It's a bit weird because the verification method is called "verifyScanResult" as well, and then switches over Get/Scan/ReverseScan requests -- should we rename the thing to "verifyReadResult" instead?
pkg/kv/kvserver/replica_evaluate_test.go line 384 at r1 (raw file):
{ // Same as above, but with replicated shared locks. name: "gets with key locking (exclusive, replicated)",
"(shared, replicated)"
…teBatch Informs cockroachdb#91545. Informs cockroachdb#100193. This commit extends TestEvaluateBatch to include shared, replicated, and shared-replicated lock acquisition using Get, Scan, and ReverseScan requests. Release note: None
This commit updates the naming of a few variables and the verifyScanResult function to better reflect the use of GetRequests in the test. Epic: None Release note: None
1a6beba to
6a3f134
Compare
nvb
left a comment
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
pkg/kv/kvserver/replica_evaluate_test.go line 321 at r1 (raw file):
Previously, arulajmani (Arul Ajmani) wrote…
nit: Should these say "getA" and "getG", here and elsewhere?
It's a bit weird because the verification method is called "verifyScanResult" as well, and then switches over
Get/Scan/ReverseScanrequests -- should we rename the thing to "verifyReadResult" instead?
Done for both.
pkg/kv/kvserver/replica_evaluate_test.go line 384 at r1 (raw file):
Previously, arulajmani (Arul Ajmani) wrote…
"(shared, replicated)"
Done.
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
CI flakes:
bors r+ |
|
Build succeeded: |
Informs #91545.
Informs #100193.
This commit extends TestEvaluateBatch to include shared, replicated, and shared-replicated lock acquisition using Get, Scan, and ReverseScan requests.
Release note: None