backupccl: add missing ctx cancel check#111231
Conversation
In cockroachdb#111159 we deduced from the stacks a situation in which the goroutine draining `spanCh` had exited due to a context cancelation but the writer was not listening for a ctx cancelation. This manifests as a stuck restore when using the non-default make simple import spans implementation. Fixes: cockroachdb#111159 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
the exact thought that went through my head. If it makes sense to you/rui I think I feel pretty good just merging it for now. |
|
TFTR! bors r=msbutler |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 6fabaf8 to blathers/backport-release-22.2-111231: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
In #111159 we deduced from the stacks a
situation in which the goroutine draining
spanChhad exited due to a context cancelation but thewriter was not listening for a ctx cancelation.
This manifests as a stuck restore when using
the non-default make simple import spans implementation.
Fixes: #111159
Release note: None