pkg/server: add an extra server startup guardrail#110377
pkg/server: add an extra server startup guardrail#110377craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
knz
left a comment
There was a problem hiding this comment.
thank you for this. Just a suggestion about phrasing.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @healthy-pod and @stevendanna)
pkg/server/server_sql.go line 1655 at r1 (raw file):
// for the tenant cluster version. if tenantActiveVersion.Version.Less(s.execCfg.Settings.Version.BinaryMinSupportedVersion()) { return errors.WithHintf(errors.Newf("preventing SQL server from starting because its minimum supported "+
the error currently is phrased using our internal technical terms, but a user wouldn't necessarily know what to do with it.
Maybe flip the phrasing in the other direction:
"executable version is too new to run the current active logical version of the tenant"
(also maybe replace "tenant" by "virtual cluster")
then also update the hint to "finalize the version upgrade to at least X.Y or downgrade the executable version to at most Z.W".
This code change prevents a SQL server from starting if its minimum supported binary version is greater than the tenant active version. Release note: None Epic: CRDB-26691
37b96b2 to
0b5306e
Compare
knz
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
|
TFTR! bors r=knz |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
bors retry |
|
Already running a review |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
This code change prevents a SQL server from starting if its minimum supported binary version is greater than the tenant active version.
Release note: None
Epic: CRDB-26691