sql: coherent handling of hidden session vars in info_schema#109872
sql: coherent handling of hidden session vars in info_schema#109872craig[bot] merged 3 commits intocockroachdb:masterfrom
Conversation
|
This change is |
|
@rafiss the second and third commit are "nice to have"; i'm not too attached to them if you don't like them. LMK |
Release note (bug fix): Certain SQL session variables are meant to be hidden from introspection but were showing up in `information_schema.session_variables`, which was incoherent with the handling in `pg_catalog.pg_settings`. This bug has now been fixed.
59c08e4 to
c46ff93
Compare
rafiss
left a comment
There was a problem hiding this comment.
thank you! the thing i'm less sure about is hiding the experimental settings. we don't do that for most experimental cluster settings. also, in the future if we start auto-generating docs for session variables, i think it could be good to include experimental settings too. however, i'm also fine to revisit this later at that point if you think it should be hidden now.
all the other changes lgtm; especially hiding the ones that are aliases
Reviewable status:
complete! 0 of 0 LGTMs obtained
ok I will restore these. |
Release note (sql change): The deprecated session variable `idle_in_session_timeout` is now hidden from introspection. (It has been known as `idle_session_timeout` for a while already.)
Release note (sql change): The session variable `ssl` is now visible through introspection for better compatibility with PostgreSQL. Release note (sql change): The session variable `session_user` is now invisible through introspection, in a way consistent with `session_authorization` and PostgreSQL.
c46ff93 to
ba3358e
Compare
|
Done. bors r=rafiss |
|
Build succeeded: |
Fixes #109870.
Epic: CRDB-28893
Release note (bug fix): Certain SQL session variables are meant
to be hidden from introspection but were showing up in
information_schema.session_variables, which was incoherent with thehandling in
pg_catalog.pg_settings. This bug has now been fixed.