Skip to content

roachtest: add npgsql tests to ignorelist; not blocklist#109863

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-roachtests
Sep 1, 2023
Merged

roachtest: add npgsql tests to ignorelist; not blocklist#109863
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-roachtests

Conversation

@rafiss
Copy link
Copy Markdown
Collaborator

@rafiss rafiss commented Sep 1, 2023

The previous commit 1928be2 accidentally put them in the wrong list. The blocklist is for tests that are expected to always fail, but a flaky test might pass sometimes.

fixes #109806
fixes #109738
Release note: None

The previous commit 1928be2
accidentally put them in the wrong list. The blocklist is for tests that
are expected to always fail, but a flaky test might pass sometimes.

Release note: None
@rafiss rafiss added the backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only label Sep 1, 2023
@rafiss rafiss requested a review from a team September 1, 2023 05:11
@rafiss rafiss requested a review from a team as a code owner September 1, 2023 05:11
@rafiss rafiss requested review from herkolategan and smg260 and removed request for a team September 1, 2023 05:11
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rafiss rafiss requested a review from annrpom September 1, 2023 15:25
@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Sep 1, 2023

tftr!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Sep 1, 2023

Build succeeded:

@craig craig bot merged commit d9c137d into cockroachdb:master Sep 1, 2023
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Sep 1, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from af6135f to blathers/backport-release-23.1-109863: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

roachtest: npgsql failed roachtest: npgsql failed

3 participants