sql,backfill: deflake TestValidationWithProtectedTS#109010
Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom Aug 18, 2023
Merged
sql,backfill: deflake TestValidationWithProtectedTS#109010craig[bot] merged 3 commits intocockroachdb:masterfrom
craig[bot] merged 3 commits intocockroachdb:masterfrom
Conversation
This test was slow enough to the point of flaking. I tracked down the problem to the metamorphic constant `kv-batch-size`. Now we set a testing knob to make sure that the value is always the production value. This also required a fix to plumb the testing knob through in one more place. Release note: None
…IC_TESTING The interpretation of this flag was flipped. Release note: None
Member
|
This change is |
fqazi
approved these changes
Aug 18, 2023
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
@rafiss Thanks for doing this!
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
This test was timing out sometimes due to low batch sizes. Release note: None
c5f7805 to
7a701ec
Compare
Collaborator
Author
|
tftr! bors r+ |
yuzefovich
approved these changes
Aug 18, 2023
Member
yuzefovich
left a comment
There was a problem hiding this comment.
Nice work tracking this down!
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status:
pkg/sql/backfill/backfill.go line 173 at r1 (raw file):
MemMonitor: cb.mon, Spec: &spec, TraceKV: traceKV,
Perhaps we should set the knob here for consistency too?
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was slow enough to the point of flaking. I tracked down the
problem to the metamorphic constant
kv-batch-size. Now we set atesting knob to make sure that the value is always the production value.
This also required a fix to plumb the testing knob through in one more
place.
fixes #106960
informs #108539
Release note: None