backupccl: deflake memory monitor restore test#108942
backupccl: deflake memory monitor restore test#108942craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
What coverage would we lose if we just did |
Deflake the TestRestoreMemoryMonitoring tests by only asserting the lower bound in the number of files produced in the backup to account for elastic CPU limiter. Fixes: cockroachdb#108239 Release note: None
eaeab16 to
149ad11
Compare
I don't think we really lose any coverage. I updated the test so that we just assert the lower bound. |
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 149ad11 to blathers/backport-release-22.2-108942: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error creating merge commit from 149ad11 to blathers/backport-release-23.1-108942: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Deflake the TestRestoreMemoryMonitoring tests by only asserting the lower bound in the number of files produced in the backup to account for elastic CPU limiter.
Fixes: #108239
Release note: None