roachtest: add ability to perform multiple upgrades in mixedversion#108773
Conversation
|
This change is |
|
There's a likely legit bug that causes
I'll let @cockroachdb/disaster-recovery deal with this failure as they see fit when it happens in the nightly build. |
41098ba to
dc5456a
Compare
smg260
left a comment
There was a problem hiding this comment.
The feature generally makes sense to me.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @herkolategan, @renatolabs, and @srosenberg)
pkg/cmd/roachtest/roachtestutil/mixedversion/mixedversion.go line 929 at r1 (raw file):
if test.options.minUpgrades > test.options.maxUpgrades { err := fmt.Errorf( "invalid test options: minUpgrades=%d maxUpgrades=%d",
minor: might make sense to be explicit about the error here.
e.g. maxUpgrades (%d) must be greater than minUpgrades (%d)
dc5456a to
48d5fb6
Compare
renatolabs
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/roachtestutil/mixedversion/mixedversion.go line 929 at r1 (raw file):
Previously, smg260 (Miral Gadani) wrote…
minor: might make sense to be explicit about the error here.
e.g.
maxUpgrades (%d) must be greater than minUpgrades (%d)
Makes sense, done.
This commit adds the ability for `mixedversion` tests to perform multiple upgrades in certain tests runs. It has been observed that certain types of errors only manifest when features are enabled in older releases, and this makes it possible for us to get some coverage for these scenarios. By default, `mixedversion` tests will perform a random number of upgrades (up to a maximum of 3). Test authors are able to override this default by providing a minimum, maximum, or exact number of upgrades test runs should go through. Epic: CRDB-19321 Release note: None
Certain features and system tables used in the test are only available in v22.2+. In addition, we are only validating our ability to restore backups taken in the previous version for now. Epic: CRDB-19321 Release note: None
48d5fb6 to
2b00746
Compare
We bump this test's timeout since it can now go through up to 2 upgrades in a test run. In the future, we'll allow the test to perform more upgrades, but more work is needed to identify known limitations in 22.1 Epic: CRDB-19321 Release note: None
|
Added another commit to adapt the new @jayshrivastava FYI. |
|
TFTR! bors r=smg260 |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 2b00746 to blathers/backport-release-23.1-108773: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This commit adds the ability for
mixedversiontests to performmultiple upgrades in certain tests runs. It has been observed that
certain types of errors only manifest when features are enabled in
older releases, and this makes it possible for us to get some coverage
for these scenarios.
By default,
mixedversiontests will perform a random number ofupgrades (up to a maximum of 3). Test authors are able to override
this default by providing a minimum, maximum, or exact number of
upgrades test runs should go through.
Epic: CRDB-19321
Release note: None