sql/resolver: rename AvoidLeased to AssertNotLeased#108681
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 14, 2023
Merged
sql/resolver: rename AvoidLeased to AssertNotLeased#108681craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
rafiss
approved these changes
Aug 14, 2023
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
nice find! glad this didn't actually cause issues
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @fqazi)
-- commits line 5 at r1:
nit: missing word "which did not ___ anything"
Previously, we had a flag to avoid leased descriptors, which did not do anything within look-up contexts. This was because this flag was never really used since skipping leased descriptors happens at a higher level with flags on the resolver. To address this, this the patch will make this flag more useful by making it an assertion that no leased descriptor is being used in these contexts. Fixes: cockroachdb#108714 Release note: None
Collaborator
Author
|
@rafiss TFTR! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
This PR was included in a batch that timed out, it will be automatically retried |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we had a flag to avoid leased descriptors, which did not do anything within look-up contexts. This was because this flag was never really used since skipping leased descriptors happens at a higher level with flags on the resolver. To address this, this
the patch will make this flag more useful by making it an assertion that no leased descriptor is being used in these contexts.
Release note: None