Skip to content

roachtest: start monitoring after NewMonitor#108554

Closed
renatolabs wants to merge 1 commit intocockroachdb:masterfrom
renatolabs:rc/roachtest-monitor-after-creation
Closed

roachtest: start monitoring after NewMonitor#108554
renatolabs wants to merge 1 commit intocockroachdb:masterfrom
renatolabs:rc/roachtest-monitor-after-creation

Conversation

@renatolabs
Copy link
Copy Markdown

Epic: none

Release note: None

@renatolabs renatolabs requested a review from a team as a code owner August 10, 2023 20:25
@renatolabs renatolabs requested review from DarrylWong and rachitgsrivastava and removed request for a team August 10, 2023 20:25
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@renatolabs
Copy link
Copy Markdown
Author

Meant to create this as a draft, as I suspect a lot of tests will break. Will run some preliminary builds on this branch first.

@renatolabs renatolabs marked this pull request as draft August 10, 2023 20:26
Epic: none

Release note: None
@renatolabs renatolabs force-pushed the rc/roachtest-monitor-after-creation branch from 9a2f71b to fa70bbf Compare August 11, 2023 13:24
@renatolabs
Copy link
Copy Markdown
Author

https://teamcity.cockroachdb.com/viewLog.html?buildId=11274314&buildTypeId=Cockroach_Nightlies_RoachtestNightlyGceBazel&tab=buildResultsDiv&branch_Cockroach_Nightlies=108554

Conclusion: monitoring as soon as NewMonitor is called is a change that would involve updating a lot of tests. Closing this PR in favour of a different approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants