roachtest: wait smaller duration before timining out lease prefs#108483
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 21, 2023
Merged
roachtest: wait smaller duration before timining out lease prefs#108483craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Previously, the `lease-preferences` roachtests would fail on the test tiemout, despite the test actually failing much earlier. 5 minutes stopping a node, the node is considered dead, and up-replication will begin. If the cluster doesn't satisfy lease preferences within that 5 minute window, the test will reliably fail -- making the remainder of the test timeout (30 or 60 minutes), wasted time. Fail earlier, by adhering to a post event timeout. This timeout set to 10 minutes. Informs: cockroachdb#108425 Epic: none Release note: None
e196675 to
664cc2c
Compare
erikgrinaker
approved these changes
Aug 11, 2023
Contributor
Author
|
TYFTR! bors r=erikgrinaker |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
lease-preferencesroachtests would fail on the testtiemout, despite the test actually failing much earlier. 5 minutes
stopping a node, the node is considered dead, and up-replication will
begin. If the cluster doesn't satisfy lease preferences within that 5
minute window, the test will reliably fail -- making the remainder of
the test timeout (30 or 60 minutes), wasted time.
Fail earlier, by adhering to a post event timeout. This timeout set to
10 minutes.
Informs: #108425
Epic: none
Release note: None