roachtest/multitenant-upgrade: hard-code predecessor version temporarily#108355
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 8, 2023
Merged
roachtest/multitenant-upgrade: hard-code predecessor version temporarily#108355craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
knz
reviewed
Aug 8, 2023
| // require.NoError(t, err) | ||
| // Hard-code the pre-decessor release to 23.1.4 until a new patch release is out (23.1.9) because | ||
| // the test is in-compatible with 23.1.{5,6,7,8} due to an erroneous PR merged on the 23.1 branch. | ||
| predecessor := "23.1.4" |
Contributor
There was a problem hiding this comment.
Thanks. Could you make this override temporary by actually encoding a condition on the output of release.LatestPredecessor? Something like:
if major == 23 and minor == 1 and patch < 7 {
predecessor = "23.1.4"
}
so that the condition automatically ceases to apply once .7 is released.
27f74ec to
e96d6b4
Compare
Contributor
|
You could also include a mention to the specific patch that was problematic and the PR that was merged to fix it. |
Hard-code the pre-decessor release to 23.1.4 until a new
patch release is out (23.1.9) because the test is in-compatible
with 23.1.{5,6,7,8} due to an erroneous PR merged on the 23.1 branch.
Release note: None
Epic: none
Contributor
Author
|
TFTR! |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard-code the pre-decessor release to 23.1.4 until a new patch release is out (23.1.9) because the test is in-compatible with 23.1.{5,6,7,8} due to an erroneous PR merged on the 23.1 branch.
Release note: None
Epic: CRDB-18499
Fixes #107851.