util/must: revert API#108272
Merged
craig[bot] merged 4 commits intocockroachdb:masterfrom Aug 11, 2023
Merged
Conversation
Member
|
This change is |
ebc8713 to
7234493
Compare
7234493 to
c568373
Compare
Contributor
Author
|
bors r+
Yeah, it's a shame, but we'll come up with something else. |
Contributor
|
Build succeeded: |
This was referenced Aug 12, 2023
This was referenced Sep 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch reverts #106508, since @RaduBerinde pointed out a performance flaw where it will often incur an allocation on the happy path due to interface boxing of the format args. Other options are considered in #108169.
We'll revisit runtime assertions with a different API that avoids this cost on the happy path.