upgrademanager: unskip TestMigrationFailure#108029
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 5, 2023
Merged
upgrademanager: unskip TestMigrationFailure#108029craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Contributor
Author
|
huh CI failed this test on another issue, let me dig |
a50f728 to
a7da1d6
Compare
msbutler
approved these changes
Aug 4, 2023
a7da1d6 to
53f2330
Compare
The test no longer fails with our change in Fixes: cockroachdb#106648 Fixes: cockroachdb#106762 Release note: None
53f2330 to
9cd15a2
Compare
Contributor
Author
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test no longer fails with our change in #107570.
Fixes: #106648
Fixes: #106762
Release note: None