Skip to content

sql: Deflake TestTxnObeysTableModificationTime#107993

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
Xiang-Gu:deflake/TestTxnObeysTableModificationTime
Aug 2, 2023
Merged

sql: Deflake TestTxnObeysTableModificationTime#107993
craig[bot] merged 1 commit intocockroachdb:masterfrom
Xiang-Gu:deflake/TestTxnObeysTableModificationTime

Conversation

@Xiang-Gu
Copy link
Copy Markdown
Contributor

@Xiang-Gu Xiang-Gu commented Aug 1, 2023

This commit refactors and simplifies this test, and a local execution with --race --stress succeeded for at least 10 minutes.

Fixes #107736
Fixes #107159
Epic: None
Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@Xiang-Gu Xiang-Gu added the backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only label Aug 1, 2023
This commit rewrites this test and a local execution with
`--race --stress` succeeded for at least 10 minutes.

Release note: None
@Xiang-Gu Xiang-Gu force-pushed the deflake/TestTxnObeysTableModificationTime branch from 9e2d5b0 to 9b74331 Compare August 2, 2023 14:58
@Xiang-Gu Xiang-Gu marked this pull request as ready for review August 2, 2023 14:59
@Xiang-Gu Xiang-Gu requested a review from a team as a code owner August 2, 2023 14:59
Copy link
Copy Markdown
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice~

@Xiang-Gu
Copy link
Copy Markdown
Contributor Author

Xiang-Gu commented Aug 2, 2023

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 2, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 2, 2023

Build succeeded:

@craig craig bot merged commit c3f3951 into cockroachdb:master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only

Projects

None yet

3 participants