server,testcluster: make more tests work with secondary tenants#107757
server,testcluster: make more tests work with secondary tenants#107757craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @herkolategan, @knz, @nkodali, @renatolabs, and @stevendanna)
pkg/testutils/testcluster/testcluster.go line 433 at r1 (raw file):
// run the migrations up to the overridden BinaryVersion. if v := tc.Servers[0].BinaryVersionOverride(); v != (roachpb.Version{}) { if _, err := tc.storageConn.Exec(`SET CLUSTER SETTING version = $1`, v.String()); err != nil {
I'm assuming we need this independent of a similar change in #107808?
pkg/server/application_api/schema_inspection_test.go line 50 at r1 (raw file):
// Disable the default test tenant for now as this tests fails with // it enabled. Tracked with #81590. DefaultTestTenant: base.TODOTestTenantDisabled,
nit: ditto for the linter.
knz
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/testutils/testcluster/testcluster.go line 433 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
I'm assuming we need this independent of a similar change in #107808?
Interesting remark. The two are indeed useful in the general case.
I'll let them merge as two separate PRs though.
pkg/server/application_api/schema_inspection_test.go line 50 at r1 (raw file):
Previously, yuzefovich (Yahor Yuzefovich) wrote…
nit: ditto for the linter.
Fixed.
Release note: None
|
TFYR bors r=yuzefovich |
|
Build succeeded: |
Epic: CRDB-18499
Informs #76378.