Skip to content

server: deflake TestServerShutdownReleasesSession#107727

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:deflake-TestServerShutdownReleasesSession
Jul 28, 2023
Merged

server: deflake TestServerShutdownReleasesSession#107727
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:deflake-TestServerShutdownReleasesSession

Conversation

@rafiss
Copy link
Copy Markdown
Collaborator

@rafiss rafiss commented Jul 27, 2023

The tenant was not being fully stopped, so the test could encounter flakes.

fixes #107592
Release note: None

The tenant was not being fully stopped, so the test could encounter
flakes.

Release note: None
@rafiss rafiss requested a review from jeffswenson July 27, 2023 16:52
@rafiss rafiss requested review from a team as code owners July 27, 2023 16:52
@rafiss rafiss requested a review from knz July 27, 2023 16:52
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@chengxiong-ruan chengxiong-ruan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice.

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Jul 27, 2023

flake was in a different test (TestTxnObeysTableModificationTime tracked in #107159)

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 27, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 27, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 28, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 28, 2023

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 28, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@craig craig bot merged commit 04c91a5 into cockroachdb:master Jul 28, 2023
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 28, 2023

Build succeeded:

@jeffswenson
Copy link
Copy Markdown
Collaborator

Good catch. Thanks!

@rafiss rafiss deleted the deflake-TestServerShutdownReleasesSession branch August 1, 2023 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

server: TestServerShutdownReleasesSession failed

5 participants