workload/ycsb: mark --read-modify-write-in-txn flag as RuntimeOnly#107726
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 27, 2023
Merged
workload/ycsb: mark --read-modify-write-in-txn flag as RuntimeOnly#107726craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The `read-modify-write-in-txn` flag was added to ycsb in cockroachdb#103117. This commit marks the flag as RuntimeOnly so that it doesn't break IMPORT when a newer version of `workload` (who knows about the flag) is run against an older version of `cockroach` (who does not). Epic: None Release note: None
Member
|
This change is |
michae2
approved these changes
Jul 27, 2023
Collaborator
michae2
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @smg260, @srosenberg, and @ZhouXing19)
sean-
approved these changes
Jul 27, 2023
Contributor
sean-
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
ZhouXing19
approved these changes
Jul 27, 2023
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
read-modify-write-in-txnflag was added to ycsb in #103117.This commit marks the flag as RuntimeOnly so that it doesn't break IMPORT when a newer version of
workload(who knows about the flag) is run against an older version ofcockroach(who does not).Epic: None
Release note: None