sql: disallow aggregate functions in ORDER BY in DELETE and UPDATE#107641
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 26, 2023
Merged
sql: disallow aggregate functions in ORDER BY in DELETE and UPDATE#107641craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit disallows aggregate functions in the context of an `ORDER BY` clause in a `DELETE` or `UPDATE` statement. An aggregate function in an `ORDER BY` would require a `GROUP BY` clause to group non-aggregate columns. A `GROUP BY` is not allowed in `DELETE` or `UPDATE` statements as it's not obvious how grouping in these statements would behave. So we simply disallow aggregates in `ORDER BY` instead. Fixes cockroachdb#107634 Release note (bug fix): A bug has been fixed that caused internal errors when using an aggregate function in an `ORDER BY` clause of a `DELETE` or `UPDATE` statement. Aggregate functions are no longer allowed in these contexts. The bug has been present since at least version 20.2.
Member
|
This change is |
michae2
approved these changes
Jul 26, 2023
Collaborator
michae2
left a comment
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit disallows aggregate functions in the context of an
ORDER BYclause in aDELETEorUPDATEstatement. An aggregatefunction in an
ORDER BYwould require aGROUP BYclause to groupnon-aggregate columns. A
GROUP BYis not allowed inDELETEorUPDATEstatements as it's not obvious how grouping in these statementswould behave. So we simply disallow aggregates in
ORDER BYinstead.Fixes #107634
Release note (bug fix): A bug has been fixed that caused internal errors
when using an aggregate function in an
ORDER BYclause of aDELETEor
UPDATEstatement. Aggregate functions are no longer allowed inthese contexts. The bug has been present since at least version 20.2.