schemachanger: deflake TestConcurrentDeclarativeSchemaChanges#107636
schemachanger: deflake TestConcurrentDeclarativeSchemaChanges#107636craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
This commit deflakes this test by checking that the second schema change actually does block because of the first one, rather than checking that it has blocked. The bug was that the latter wasn't always guaranteed to happen because we didn't force the schema changes to run in parallel. Fixes cockroachdb#106732. Release note: None
7ba4f16 to
abc0966
Compare
|
Thanks for the review! bors r+ |
|
Build failed (retrying...): |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from abc0966 to blathers/backport-release-22.2-107636: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error creating merge commit from abc0966 to blathers/backport-release-23.1-107636: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This commit deflakes this test by checking that the second schema change actually does block because of the first one, rather than checking that it has blocked. The bug was that the latter wasn't always guaranteed to happen because we didn't force the schema changes to run in parallel.
Fixes #106732.
Release note: None