Skip to content

kvcoord: make rangefeed connection class TenantReadOnly#107267

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
erikgrinaker:rangefeed-conn-class-tenant
Jul 20, 2023
Merged

kvcoord: make rangefeed connection class TenantReadOnly#107267
craig[bot] merged 1 commit intocockroachdb:masterfrom
erikgrinaker:rangefeed-conn-class-tenant

Conversation

@erikgrinaker
Copy link
Copy Markdown
Contributor

@erikgrinaker erikgrinaker commented Jul 20, 2023

Otherwise, the setting won't have any effect for tenants, always falling through to the default.

Resolves #106895.
Epic: none
Release note: None

Otherwise, the setting won't have any effect for tenants, always falling
through to the default.

Epic: none
Release note: None
@erikgrinaker erikgrinaker added backport-22.2.x backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only labels Jul 20, 2023
@erikgrinaker erikgrinaker self-assigned this Jul 20, 2023
@erikgrinaker erikgrinaker requested a review from a team July 20, 2023 15:08
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jul 20, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@erikgrinaker
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 20, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kvcoord: kv.rangefeed.use_dedicated_connection_class.enabled must be TenantReadOnly

3 participants