dev: perform chmod in /tmp, not /artifacts#107113
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 19, 2023
Merged
dev: perform chmod in /tmp, not /artifacts#107113craig[bot] merged 1 commit intocockroachdb:masterfrom
chmod in /tmp, not /artifacts#107113craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
0407ea5 to
82ce5ae
Compare
This avoids an error in case your `artifacts` directory has some restrictive permissions. There's no functional difference here, we just copy to `/tmp` and do the `chmod` there before copying to the final destination directory. [Internal discussion](https://cockroachlabs.slack.com/archives/C019A8NANH0/p1689598801368169) Epic: none Release note: None
rail
approved these changes
Jul 18, 2023
Collaborator
Author
|
bors r=rail |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids an error in case your
artifactsdirectory has some restrictive permissions. There's no functional difference here, we just copy to/tmpand do thechmodthere before copying to the final destination directory.Internal discussion
Epic: none
Release note: None