asim: add random predefined cluster config selection#107075
asim: add random predefined cluster config selection#107075craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
a8832ac to
3a1140e
Compare
3a3d69d to
3ac9cc7
Compare
2bf7525 to
28ad48a
Compare
kvoli
left a comment
There was a problem hiding this comment.
Are the first 3 commits from the prior PRs? Could you add a note, or just rebase once these merge.
Only 1 comment on the last commit regarding the added test expectation.
Reviewed 1 of 1 files at r1, 2 of 2 files at r2, 6 of 6 files at r3, 6 of 6 files at r4, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @wenyihu6)
pkg/kv/kvserver/asim/state/config_loader.go line 267 at r4 (raw file):
// LoadClusterInfo adds stores to State. func (c ClusterInfo) GetNumOfStores() (totalStores int) { for _, r := range c.Regions {
Should we also specify storesPerNode explicitly in the ClusterInfos above?
Also could you remind me where GetNumOfStores is going to be used? Is it just in testing atm?
|
The first three commits are from #107696. |
|
Previously, kvoli (Austen) wrote…
Discussed offline - removed them. |
kvoli
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status:
This patch takes the first step towards a randomized framework by enabling asim testing to randomly select a cluster information configuration from a set of predefined choices. These choices are hardcoded and represent common cluster configurations. TestRandomized now takes in `true` for randOptions.cluster to enable random cluster config selection. This provides two modes for cluster generation: 1. Default: currently set to 3 nodes and 1 store per node 2. Random: randomly select a predefined cluster info Part of: cockroachdb#106311 Release note: None
|
Last commit was to rebase onto master after merging the first three commits. Will merge this PR after CI goes green. |
|
TFTR! bors r=kvoli |
|
Build succeeded: |
This patch takes the first step towards a randomized framework by enabling asim
testing to randomly select a cluster information configuration from a set of
predefined choices. These choices are hardcoded and represent common cluster
configurations.
TestRandomized now takes in
truefor randOptions.cluster to enable randomcluster config selection. This provides two modes for cluster generation:
Part of: #106311
Release note: None